Skip to content

Conversation

@AffectedArc07
Copy link
Member

What Does This PR Do

Splits rustlibs into a 515 and a 516 library.

This required extensive changes to the build script, tweaks to rustlibs itself to make it work on both versions, and even updates to byondapi-rs.

This is currently DNM while I wait for spacestation13/byondapi-rs#12 because I aint having this in repo with my own fork listed as the dependency.

Why It's Good For The Game

Version compat is nice. Also the sheer fucking irony that I drop this on the day 516 goes into stable.

image

Testing

Tested server launch for MILLA lag on the following versions:

  • 515.1633
  • 516.1649
  • 516.1657

No further testing was done


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑 AffectedArc07
experiment: Added an unholy system to cross-byond compat for the atmos library.
/:cl:

@AffectedArc07 AffectedArc07 marked this pull request as draft March 5, 2025 21:20
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Mar 5, 2025
@Stealthii
Copy link
Contributor

Stealthii commented Mar 6, 2025

spacestation13/byondapi-rs#12 merged upstream and released as 0.5.14.

@AffectedArc07
Copy link
Member Author

spacestation13/byondapi-rs#12 merged upstream and released as 0.5.14.

Aware, will sort when I can

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Mar 8, 2025
@AffectedArc07
Copy link
Member Author

Ready for TM

@AffectedArc07 AffectedArc07 mentioned this pull request Mar 9, 2025
1 task
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Mar 9, 2025
@AffectedArc07 AffectedArc07 marked this pull request as ready for review March 13, 2025 16:11
@AffectedArc07 AffectedArc07 changed the title [DNM] The most unholy solution to 515 and 516 rustlibs [READY] The most unholy solution to 515 and 516 rustlibs Mar 13, 2025
@Burzah Burzah added this pull request to the merge queue Mar 13, 2025
Merged via the queue into ParadiseSS13:master with commit 7b40fe6 Mar 13, 2025
19 checks passed
m-dzianishchyts pushed a commit to m-dzianishchyts/Paradise-SS220 that referenced this pull request Mar 16, 2025
m-dzianishchyts pushed a commit to m-dzianishchyts/Paradise-SS220 that referenced this pull request Mar 16, 2025
…3#28590)

* What in the heck is this

* Tweaks I should have made before opening the PR

* gah

* Fix if () spacing issue

* Use the proper package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-Status: Awaiting merge This PR is ready for merge Testmerge Active This PR is currently testmerged on production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants