-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[READY] The most unholy solution to 515 and 516 rustlibs #28590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuga-git
approved these changes
Mar 5, 2025
Contributor
|
spacestation13/byondapi-rs#12 merged upstream and released as |
Member
Author
Aware, will sort when I can |
Member
Author
|
Ready for TM |
1 task
Burzah
approved these changes
Mar 13, 2025
1 task
m-dzianishchyts
pushed a commit
to m-dzianishchyts/Paradise-SS220
that referenced
this pull request
Mar 16, 2025
m-dzianishchyts
pushed a commit
to m-dzianishchyts/Paradise-SS220
that referenced
this pull request
Mar 16, 2025
…3#28590) * What in the heck is this * Tweaks I should have made before opening the PR * gah * Fix if () spacing issue * Use the proper package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting merge
This PR is ready for merge
Testmerge Active
This PR is currently testmerged on production
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Splits
rustlibsinto a 515 and a 516 library.This required extensive changes to the build script, tweaks to rustlibs itself to make it work on both versions, and even updates to byondapi-rs.
This is currently DNM while I wait for spacestation13/byondapi-rs#12 because I aint having this in repo with my own fork listed as the dependency.
Why It's Good For The Game
Version compat is nice. Also the sheer fucking irony that I drop this on the day 516 goes into stable.
Testing
Tested server launch for MILLA lag on the following versions:
No further testing was done
Declaration
Changelog
🆑 AffectedArc07
experiment: Added an unholy system to cross-byond compat for the atmos library.
/:cl: