submap feature: singletons #28620
Merged
submap feature: singletons #28620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
!build_rust |
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
ParadiseSS13-Bot
added
-Status: Awaiting review
Member
|
Requesting a dnm until #28590 is in |
warriorstar-orion
changed the title
Contributor
Author
Member
|
!build_rust |
Contributor
|
Building Rust library failed, see the action run log for details: https://github.com/ParadiseSS13/Paradise/actions/runs/13865713624 |
Contributor
Author
|
!build_rust |
AffectedArc07
approved these changes
Mar 15, 2025
Member
AffectedArc07
left a comment
AffectedArc07
left a comment
There was a problem hiding this comment.
Looks fine to me but I aint no rusthead
warriorstar-orion
changed the title
Contrabang
approved these changes
Mar 19, 2025
ParadiseSS13-Bot
added
-Status: Awaiting merge
Burzah
approved these changes
Mar 20, 2025
Burzah
added
the
Code Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR adds a feature to submaps called "singletons", which allows extract markers to have a shared name, even across submap operations, eliminating submaps with the same name from the selection pool.
Why It's Good For The Game
Currently submap operations are discrete, and no information is shared between them. That means if you have, for example, a map with four submaps, and each submap has a unique version of multiple departments, it's possible that you may end up with two command departments, or three science departments, etc. By adding singleton IDs, we can mark the submaps by department name, and the alternative versions of those departments won't be used for the next submap.
Testing
With the example map and submaps:
Each submap with a different floor color was given the same singleton ID.
Several sample outputs:
Before
After
Declaration
Changelog
NPFC