-
Notifications
You must be signed in to change notification settings - Fork 482
Calib workflow #8736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calib workflow #8736
Conversation
d7a88a5 to
e56274f
Compare
davidrohr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine with me, just consider my comment below.
d191996 to
abcbf2e
Compare
abcbf2e to
8efba2f
Compare
8efba2f to
39c5b18
Compare
|
Hello @martenole , @davidrohr , The last commit should enable the calibration in the main workflow, if needed (see discussion in #8668 (review)). |
011058f to
64463c3
Compare
64463c3 to
a7185a1
Compare
b429b0b to
0ebeacd
Compare
|
Back to WIP because it needs AliceO2Group/O2DPG#375 |
|
@martenole , in case you want to test, you need to run with: WORKFLOW_PARAMETERS="CALIB,${WORKFLOW_PARAMETERS}" and define the CCDBPATH. |
8902658 to
8421876
Compare
adc703a to
bc4d686
Compare
|
Hi Chiara, |
|
Hi Ole, We changed a few things this morning, and I did not have the time to try yet. So it might well be that something needs to be fixed now. Sorry for the inconvenience. Chiara |
7e786bb to
fa9e3a6
Compare
|
Hi @martenole , Yes, I had removed sourcing of all files, not just checking whether there were sourced :-) Chiara |
|
For me the following works (with master of O2DPG) - in the following, setenv_extra sets
--> builds the workflow appending to it the calibration procedures which otherwise should be run on the aggregator. No output nor input proxies:
---> works correctly, the calib processes are not appended, but the output proxy is and the data specs are correctly built:
---> all correct: specs build correctly, raw proxy as well, calib processes appended: (ccdb-populator not attached as we don't pass CCDB_POPULATOR_UPLOAD_PATH). |
|
Considering AliceO2Group/O2DPG#390 (comment), I am now removing [WIP]. |
fa9e3a6 to
90155e0
Compare
|
Hello @shahor02 , @davidrohr , @martenole , As discussed via email, I would merge this PR (I need @shahor02 or @davidrohr to do so). It should not affect the data taking, as we have not yet enabled calibrations, but it will help to test more. Thanks, Chiara |
|
Can you check if the fullCI failure is unrelated, though? |
|
Hi @ktf , I don't see the full logs, but to me it looks like problems in compilation (memory?) and then in the AODs. So not related to this PR. Can you also take a look? Chiara |
shahor02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sim_challenge fails in aod-producer, unrelated, merging
@davidrohr
Needs AliceO2Group/O2DPG#373
Updated after some changes for TRD: also AliceO2Group/O2DPG#375 is needed