Skip to content

Conversation

@chiarazampolli
Copy link
Collaborator

No description provided.

@davidrohr
Copy link
Collaborator

@chiarazampolli : How is it happening that it is sourced twice?
Probably in your local tests where you run the dpl-workflow.sh and the aggregator as one workflow?
I assume in that case we have the same problem also with setenv.sh and with getCommonArgs.sh?
Perhaps we could just change the aggregator script to not source anything if CALIB_LOCAL_AGGREGATOR=1? (as suggested in AliceO2Group/AliceO2#8736)
Or we have to add protection to the other scripts as well.
Although, in general I am also not principally against putting protections everywhere.

@chiarazampolli
Copy link
Collaborator Author

I added protections everywhere (unless I forgot something), just for safety.
The only things I did not touch is the dpl-workflow.sh, the setenv.sh and getCommonArgs.sh

@chiarazampolli
Copy link
Collaborator Author

Ciao @davidrohr ,

If this is fine, could you merge it? Then, since there are new changes, I will do some tests for the one in O2 before removing the WIP.

Chiara

@davidrohr davidrohr merged commit f65841c into AliceO2Group:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants