Skip to content

Conversation

@chiarazampolli
Copy link
Collaborator

@chiarazampolli chiarazampolli commented May 6, 2022

@davidrohr , @shahor02

@davidrohr : if you want, the function add_semicolon_separated() can be incorporated in add_common_separated() in a more general one where one passes also the separator.

Needed by AliceO2Group/AliceO2#8736

@chiarazampolli chiarazampolli changed the title [WIP] adding calib-workflow adding calib-workflow May 6, 2022
@chiarazampolli
Copy link
Collaborator Author

Hi @davidrohr .

This setting work locally. Maybe it is good enough to start with?

Chiara

@davidrohr
Copy link
Collaborator

Hi @davidrohr .

This setting work locally. Maybe it is good enough to start with?

Chiara

Sure, fine with me, please merge it when you think it is ready

@chiarazampolli
Copy link
Collaborator Author

I will then merge now.
But I don't see the tests with the FST, did they run?

@davidrohr
Copy link
Collaborator

@TimoWilken : The CI with the FST does only show up after a while, not immediately when the PR is created.
Do you know why?

@chiarazampolli
Copy link
Collaborator Author

I will merge it, as it is not used in the FST (the extra function in setenv.sh is not called there).
@davidrohr : can I then remove the WIP from the PR in O2, or should one wait that O2DPG is tagged? I mean, is the CI in O2 running with master of O2DPG?

@davidrohr
Copy link
Collaborator

no need to wait for a tag, just merge here, and then remove the WIP in O2.

@chiarazampolli chiarazampolli merged commit f5907fb into AliceO2Group:master May 6, 2022
@chiarazampolli
Copy link
Collaborator Author

Done, thanks for the feedback.

@TimoWilken
Copy link
Contributor

@TimoWilken : The CI with the FST does only show up after a while, not immediately when the PR is created. Do you know why?

This is because the check is not marked as "required". In this case, GitHub doesn't know the check exists, and only marks it as "pending" once the CI builder reports it for the specific commit for the first time. This can take a bit of time if the builder is busy at the time the PR is submitted.

If it is "required", then GitHub marks it as "expected" until the CI builder reports it for the first time, whereupon it changes from "expected" to "pending".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants