-
Notifications
You must be signed in to change notification settings - Fork 180
adding calib-workflow #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding calib-workflow #373
Conversation
f93558c to
a07aad4
Compare
|
Hi @davidrohr . This setting work locally. Maybe it is good enough to start with? Chiara |
Sure, fine with me, please merge it when you think it is ready |
|
I will then merge now. |
|
@TimoWilken : The CI with the FST does only show up after a while, not immediately when the PR is created. |
|
I will merge it, as it is not used in the FST (the extra function in setenv.sh is not called there). |
|
no need to wait for a tag, just merge here, and then remove the WIP in O2. |
|
Done, thanks for the feedback. |
This is because the check is not marked as "required". In this case, GitHub doesn't know the check exists, and only marks it as "pending" once the CI builder reports it for the specific commit for the first time. This can take a bit of time if the builder is busy at the time the PR is submitted. If it is "required", then GitHub marks it as "expected" until the CI builder reports it for the first time, whereupon it changes from "expected" to "pending". |
@davidrohr , @shahor02
@davidrohr : if you want, the function
add_semicolon_separated()can be incorporated inadd_common_separated()in a more general one where one passes also the separator.Needed by AliceO2Group/AliceO2#8736