Skip to content

Conversation

@puddly
Copy link
Contributor

@puddly puddly commented Dec 31, 2025

EZSP v18 changed the format of APS frames. To account for this, I've moved more processing into the protocol-specific handlers and have switched to the zigpy event bus for these new events.

As it turns out, the struct indeed changed...but the wire format was never updated to account for the new fields. If you use then, the coordinator crashes 😄. So this protocol version bump is effectively just changing a single parameter in a command we do not use from uint8_t to uint16_t.

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.54%. Comparing base (9e31738) to head (185284a).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #704   +/-   ##
=======================================
  Coverage   99.53%   99.54%           
=======================================
  Files          58       61    +3     
  Lines        4128     4147   +19     
=======================================
+ Hits         4109     4128   +19     
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly merged commit 54d003b into zigpy:dev Jan 2, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants