drivers: ethernet: dsa_nxp_imx_netc: fix zephyr random mac #94798
Conversation
tswaehn
force-pushed
the
nxp-dsa-random-mac
branch
from
ee4a0fb to
fb7a685
Compare
zephyrbot
added
area: Ethernet
platform: NXP Drivers
zephyrbot
requested review from
dbaluta,
decsny,
dleach02,
jukkar,
lmajewski,
maass-hamburg,
manuargue,
mmahadevan108,
pdgendt,
rlubos and
ssharks
tswaehn
force-pushed
the
nxp-dsa-random-mac
branch
from
fb7a685 to
587a462
Compare
|
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
this is actually a bug technically, boolean prop should not be read with _HAS_PROP macro, @tswaehn can you please fix PR to use the right macro like @maass-hamburg said |
|
I used |
tswaehn
force-pushed
the
nxp-dsa-random-mac
branch
from
587a462 to
7684691
Compare
tswaehn
force-pushed
the
nxp-dsa-random-mac
branch
from
7684691 to
1ef6b48
Compare
tswaehn
force-pushed
the
nxp-dsa-random-mac
branch
from
1ef6b48 to
21e7c49
Compare
| }; \ | ||
| struct dsa_port_config dsa_##n##_##port##_config = { \ | ||
| .use_random_mac_addr = DT_NODE_HAS_PROP(port, zephyr_random_mac_address), \ | ||
| .use_random_mac_addr = DT_PROP(port, zephyr_random_mac_address), \ |
There was a problem hiding this comment.
Replace the <tab> with spaces to be consistent with the surrounding code, please.
There was a problem hiding this comment.
btw. after closing this, we should probably follow the scheme from PR #100619
tswaehn
force-pushed
the
nxp-dsa-random-mac
branch
from
21e7c49 to
148f373
Compare
zephyr,random-mac-address defaults to 0 or 1, which is always available in generated code. so we can use the value itself. Signed-off-by: Sven Ginka <s.ginka@sensry.de>
tswaehn
force-pushed
the
nxp-dsa-random-mac
branch
from
148f373 to
99283a5
Compare
|
10 participants
zephyr,random-mac-addressdefaults to 0 or 1, which is always available in generated code. so we can use the value itself.actually just replaced
DT_NODE_HAS_PROPby
DT_PROP