Sy1xx/ethernet fix #94785
Merged
Sy1xx/ethernet fix #94785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed invalid arguments. Signed-off-by: Sven Ginka <s.ginka@sensry.de>
tswaehn
force-pushed
the
sy1xx/ethernet-fix
branch
from
483fd85 to
c359d27
Compare
tswaehn
force-pushed
the
sy1xx/ethernet-fix
branch
from
c359d27 to
9503cc0
Compare
pdgendt
reviewed
Aug 21, 2025
Contributor
pdgendt
left a comment
pdgendt
left a comment
There was a problem hiding this comment.
The same mistake should be fixed at these locations, could you apply them while you're at it?
tswaehn
force-pushed
the
sy1xx/ethernet-fix
branch
from
9503cc0 to
d08af17
Compare
pdgendt
previously approved these changes
Aug 21, 2025
Contributor
Author
sure, will create separate PR |
maass-hamburg
requested changes
Aug 21, 2025
casting the address to uint32_t removes the compiler warning. Signed-off-by: Sven Ginka <s.ginka@sensry.de>
before that commit, random mac was used even when defining zephyr,random-mac-address to false. Signed-off-by: Sven Ginka <s.ginka@sensry.de>
tswaehn
force-pushed
the
sy1xx/ethernet-fix
branch
from
d08af17 to
e9cfa0e
Compare
Contributor
Author
pdgendt
approved these changes
Aug 21, 2025
|
maass-hamburg
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zephyr,random-mac-addressnote, that when not defining
zephyr,random-mac-addressit will be generated to:zephyr/include/generated/zephyr/devicetree_generated.h