Skip to content

Create CITATION.cff for DOI and a small bug fix to the hardware interface #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdullah-ukaea merged 4 commits into from
Dec 17, 2025
Merged

Create CITATION.cff for DOI and a small bug fix to the hardware interface #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
198a1e7
first draft of citation file
abdullah-ukaea Dec 16, 2025
ac94444
updated DOI
abdullah-ukaea Dec 17, 2025
291799a
Update CRCOpenHardware on_init declaration to use HardwareComponentIn…
abdullah-ukaea Dec 17, 2025
c6f330c
Update CRCOpenHardware::on_init implementation to take HardwareCompon…
abdullah-ukaea Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CITATION.cff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
cff-version: 1.2.0
message: "If you use this software, please cite it as below."
type: software
title: "UKAEA ROS 2 Driver for Comau CRCOpen"
authors:
- family-names: "Slater"
given-names: "Adam"
- family-names: "Saleem"
given-names: "Abdullah"
version: 0.5.0
date-released: 2025-10-17
url: "https://github.com/ukaea/CRCOpenROS2Driver"
license: "Apache-2.0"
doi: "10.5281/zenodo.TBD"
2 changes: 1 addition & 1 deletion crcopen_hardware/include/crcopen_hardware.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class CRCOpenHardware
* @return SUCCESS if initialized; FAILURE if parameters are missing/invalid; ERROR otherwise.
* @post UNCONFIGURED state on success.
*/
hardware_interface::CallbackReturn on_init(const hardware_interface::HardwareInfo & info) override;
hardware_interface::CallbackReturn on_init(const hardware_interface::HardwareComponentInterfaceParams & params) override;

/**
* @brief Export per-joint state interfaces.
Expand Down
5 changes: 3 additions & 2 deletions crcopen_hardware/src/crcopen_hardware.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,11 @@ namespace crcopen_hardware
return;
}

hardware_interface::CallbackReturn CRCOpenHardware::on_init(const hardware_interface::HardwareInfo &info)
hardware_interface::CallbackReturn CRCOpenHardware::on_init(const hardware_interface::HardwareComponentInterfaceParams & params)
{

RCLCPP_INFO(rclcpp::get_logger(LOG_NAME), "on_init");
if (hardware_interface::SystemInterface::on_init(info) != hardware_interface::CallbackReturn::SUCCESS)
if (hardware_interface::SystemInterface::on_init(params) != hardware_interface::CallbackReturn::SUCCESS)
{
return hardware_interface::CallbackReturn::ERROR;
}
Expand Down