Skip to content

Add background color customization #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
teramako merged 6 commits into from
May 11, 2025
Merged

Add background color customization #22

teramako merged 6 commits into from
May 11, 2025

Conversation

@Nutzzz
Copy link
Contributor

@Nutzzz Nutzzz commented May 9, 2025 •
edited
Loading

It looks like you were thinking about implementing this in #20 , so I figured I'd help out.

EDIT: Oops, I actually based it on #20.

@Nutzzz
Copy link
Contributor Author

Nutzzz commented May 9, 2025 •
edited
Loading

Tests were fixed in #21 .

@Nutzzz
Copy link
Contributor Author

Nutzzz commented May 9, 2025 •
edited
Loading

Hm... Somewhere along the line -t (disabling transparency) was broken with GIF (something to do with palette transparency?). It was working with #18 .

@teramako
Copy link
Owner

teramako commented May 9, 2025

Hm... Somewhere along the line -t (disabling transparency) was broken with GIF (something to do with palette transparency?). It was working with #18 .

I think PR #20 commit (cbd1d7b) fixed it. Can you rebase the main branch and give it a try?
Also, the test workflow failure has been fixed (e140b04).

@Nutzzz
Copy link
Contributor Author

Nutzzz commented May 9, 2025 •
edited
Loading

I think PR #20 commit (cbd1d7b) fixed it. Can you rebase the main branch and give it a try?

You're right, it's mostly fixed, but on the main branch, I've still got an issue where it looks like top-left transparency is being applied in addition to palette background color transparency.
elephant-eyebug

EDIT: This PR seems good.

@Nutzzz Nutzzz mentioned this pull request May 9, 2025
Closed
teramako
teramako approved these changes May 11, 2025
View reviewed changes
Copy link
Owner

@teramako teramako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature.
🚀

@teramako teramako merged commit 2fabdf6 into teramako:main May 11, 2025
1 check passed
@Nutzzz Nutzzz deleted the custombg branch May 11, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teramako teramako teramako approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nutzzz @teramako