Skip to content

Provide dockerfile with composer #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
katzefudder wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Provide dockerfile with composer #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0e1d32
added Dockerfile and README.md
katzefudder Jun 7, 2017
70c55dd
run examples via Docker
katzefudder Jun 7, 2017
0676e68
debian frontend noninteractive added
Jun 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
FROM ubuntu:16.04

RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
curl git zip php php-dom php-curl php-common php-xdebug\
&& apt-get clean

# * * * * * * * * * install composer
RUN curl --silent --show-error https://getcomposer.org/installer | php && mv /composer.phar /usr/local/bin/composer

# * * * * * * * * * clean up
RUN rm -r /var/lib/apt/lists/*

ADD . /app

WORKDIR /app

RUN composer install

CMD ["vendor/bin/phpunit"]
13 changes: 13 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,16 @@ Run the tests
```
./vendor/bin/phpunit
```

## Use Docker for testing
We provide a Dockerfile with Ubuntu 16.04 and PHP7
Start testing via the following:
```
docker build -t sofortlib .
docker run -ti -v $(pwd):/app sofortlib bash -c "composer install && vendor/bin/phpunit"
Copy link
Contributor

@0x20h 0x20h Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker run sofortlib sould be sufficient here as you add the lib on build time, correct?

Copy link
Contributor Author

@katzefudder katzefudder Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could run it like that to have all tests run, correct. But think about someone who'd like to somehow "interact" with the code... you run unit tests by building the container, that should be quite sufficient to run it afterwards and edit files.
But by mounting your files into the container, you could simply use it e.g. for development reasons

```

## Use Docker to run examples
```
docker run -ti -v $(pwd):/app sofortlib bash -c "php examples/Paycode.php"
```