Provide dockerfile with composer #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasuLief
approved these changes
Jun 8, 2017
0x20h
reviewed
Jun 8, 2017
| Start testing via the following: | ||
| ``` | ||
| docker build -t sofortlib . | ||
| docker run -ti -v $(pwd):/app sofortlib bash -c "composer install && vendor/bin/phpunit" |
Contributor
There was a problem hiding this comment.
docker run sofortlib sould be sufficient here as you add the lib on build time, correct?
Contributor
Author
There was a problem hiding this comment.
You could run it like that to have all tests run, correct. But think about someone who'd like to somehow "interact" with the code... you run unit tests by building the container, that should be quite sufficient to run it afterwards and edit files.
But by mounting your files into the container, you could simply use it e.g. for development reasons
Dockerfile
Outdated
| @@ -0,0 +1,19 @@ | |||
| FROM ubuntu:16.04 | |||
|
|
|||
| RUN apt-get update && apt-get install -y \ | |||
Contributor
There was a problem hiding this comment.
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get ins...
0x20h
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for convenience: Dockerfile with PHP7 for testing purposes
You simply need Docker installed on your machine to start testing