Skip to content

Add insecure-dep test task to Makefile and CI #8464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uvizhe wants to merge 4 commits into
base: unstable
Choose a base branch
from
+8 −0
Open

Add insecure-dep test task to Makefile and CI #8464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a99a78d
Add insecure-dep test task to Makefile and CI
uvizhe Nov 25, 2025
f70d3ae
Apply review suggestions
uvizhe Dec 23, 2025
3723049
Do not rely on tty
uvizhe Dec 23, 2025
df3a0b8
Make pure dash version + remove obsolete comment
uvizhe Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,8 @@ jobs:
run: make cargo-fmt
- name: Lint code for quality and style with Clippy
run: make lint-full
- name: Check dependencies for unencrypted HTTP links
run: make insecure-deps
- name: Certify Cargo.lock freshness
run: git diff --exit-code Cargo.lock
- name: Typecheck benchmark code without running it
Expand Down
6 changes: 6 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,12 @@ vendor:
udeps:
cargo +$(PINNED_NIGHTLY) udeps --tests --all-targets --release --features "$(TEST_FEATURES)"

# Checks dependencies for unencrypted HTTP links
insecure-deps:
BAD_LINKS=`find -name Cargo.toml | xargs grep -P "git\s?=\s?[\"']http:"`; \
if [ "_$$BAD_LINKS" = "_" ]; then echo "All Git dependencies use secure HTTPS"; \
else echo "$$BAD_LINKS"; echo "Using plain HTTP in dependencies is forbidden"; false; fi

# Performs a `cargo` clean and cleans the `ef_tests` directory.
clean:
cargo clean
Expand Down