Add insecure-dep test task to Makefile and CI #8464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oops, I did not notice there's already another PR on the same issue. Feel free to close this |
chong-he
requested changes
Dec 23, 2025
Makefile
Outdated
Comment on lines
302
to
355
| bash -c \ | ||
| "find -name Cargo.toml \ | ||
| | xargs grep -P \"git\s?=\s?[\\\"']http:\" \ | ||
| | tee /dev/tty \ | ||
| | [ \`wc -l\` == 0 ] || (echo \"Using plain HTTP in dependencies is forbidden\" && false)" | ||
|
|
Member
There was a problem hiding this comment.
We could add a message to display when no http link is found (the all good case)
chong-he
added
waiting-on-author
uvizhe
force-pushed
the
check-insecure-deps
branch
from
fc90403 to
0521750
Compare
uvizhe
force-pushed
the
check-insecure-deps
branch
from
0521750 to
f70d3ae
Compare
chong-he
reviewed
Dec 24, 2025
Makefile
Outdated
| cargo +$(PINNED_NIGHTLY) udeps --tests --all-targets --release --features "$(TEST_FEATURES)" | ||
|
|
||
| # Checks dependencies for unencrypted HTTP links | ||
| # Tee preserves output. If there are matches, print a message and return 1 |
Member
There was a problem hiding this comment.
This line is not relevant now
Suggested change
| # Tee preserves output. If there are matches, print a message and return 1 |
Makefile
Outdated
Comment on lines
348
to
349
| .ONESHELL: | ||
| SHELL = /bin/bash |
Member
There was a problem hiding this comment.
These two lines seem not necessary, we can have the command directly (need to tweak a bit the command) to check for http links, and then can error or exit 1 if found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#8106
Proposed Changes
I added
insecure-depstarget to Makefile and a new step intocheck-codesection of test-suite CI workflow that uses the former.That bash multiliner is not ideal, I'd prefer a cargo plugin instead but none exists.
I also changed Cargo.toml to test that the new CI check works. Once we see a pipeline fails, I revert the change.