contracts: fix lowering final declaration without trailing semicolon #149722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
dawidl022
force-pushed
the
contracts/fix/parsing-compound-statements
branch
from
5d50b54 to
0743e5a
Compare
This comment has been minimized.
This comment has been minimized.
dawidl022
force-pushed
the
contracts/fix/parsing-compound-statements
branch
from
0743e5a to
5db6d3a
Compare
Kivooeo
reviewed
Dec 6, 2025
jieyouxu
reviewed
Dec 7, 2025
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Lowering for contract delcarations incorrectly handled the final declaration statement when it didn't end in a semicolon. This change fixes the issue.
dawidl022
force-pushed
the
contracts/fix/parsing-compound-statements
branch
from
5db6d3a to
d54fee8
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 8, 2025
…warning-in-tests, r=Kivooeo,jieyouxu contracts: clean up feature flag warning duplicated across tests There is no need for every contracts test to assert the same warning for using the `contracts` feature flag, as such use `#![expect(incomplete_features)]` in the tests, and add one test to specifically check for the warning. Making this change has been discussed in the comments of rust-lang#149722. Contracts tracking issue: rust-lang#128044 r? Kivooeo
bors
added a commit
that referenced
this pull request
Dec 8, 2025
Rollup of 8 pull requests Successful merges: - #148935 (Fix division syntax in doc comments) - #149207 (Add `ilog10` result range hints) - #149676 (Tidying up tests/ui/issues tests [3/N]) - #149710 (Move ambient gdb discovery from compiletest to bootstrap) - #149714 (Check associated type where-clauses for lifetimes) - #149722 (contracts: fix lowering final declaration without trailing semicolon) - #149736 (contracts: clean up feature flag warning duplicated across tests) - #149739 (mailmap: add binarycat) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 8, 2025
Rollup merge of #149736 - dawidl022:contracts/chore/cleanup-warning-in-tests, r=Kivooeo,jieyouxu contracts: clean up feature flag warning duplicated across tests There is no need for every contracts test to assert the same warning for using the `contracts` feature flag, as such use `#![expect(incomplete_features)]` in the tests, and add one test to specifically check for the warning. Making this change has been discussed in the comments of #149722. Contracts tracking issue: #128044 r? Kivooeo
rust-timer
added a commit
that referenced
this pull request
Dec 8, 2025
Rollup merge of #149722 - dawidl022:contracts/fix/parsing-compound-statements, r=jieyouxu contracts: fix lowering final declaration without trailing semicolon Lowering for contract delcarations introduced in #144444 incorrectly handled the final declaration statement when it didn't end in a semicolon. This change fixes the issue. See the included regression test for the minimal reproducible example. Contracts tracking issue: #128044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering for contract delcarations introduced in #144444 incorrectly handled the final declaration statement when it didn't end in a semicolon. This change fixes the issue.
See the included regression test for the minimal reproducible example.
Contracts tracking issue: #128044