Rollup of 8 pull requests #149750
Merged
Rollup of 8 pull requests #149750
+596
−763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mod` is a keyword in Rust, and since we're talking about remainders we should be using division syntax here.
While some of this information is needed by debugger discovery, it is also needed by non-debuginfo tests, so the code doesn't belong in the `debuggers` module.
Lowering for contract delcarations incorrectly handled the final declaration statement when it didn't end in a semicolon. This change fixes the issue.
There is no need for every contracts test to assert the same warning for using the `contracts` feature flag, as such use `#![expect(incomplete_features)]` in the tests, and add one test to specifically check for the warning.
Merged tests/ui/typeck/non-function-call-error-2 with tests/ui/typeck/non-function-call-error Add comment to tests/ui/traits/normalize-associated-type-in-where-clause.rs Merged tests/ui/privacy/private-item-simple-2.rs with tests/ui/privacy/private-item-simple.rs Merged tests/ui/str/str-add-operator-2.rs with tests/ui/str/str-add-operator.rs Add comment to tests/ui/imports/duplicate-empty-imports.rs Add comment to tests/ui/for-loop-while/nested-loop-break-unit.rs Add comment to tests/ui/match/match-ref-option-pattern.rs Add comment to tests/ui/closures/simple-capture-and-call.rs Add comment to tests/ui/type/never-type-inference-fail.rs Add comment to tests/ui/match/match-stack-overflow-72933.rs
…-Simulacrum Fix division syntax in doc comments `mod` is a keyword in Rust, and since we're talking about remainders we should be using division syntax here.
…ts, r=Mark-Simulacrum Add `ilog10` result range hints This PR adds hints that the return value of `T::ilog10` will never exceed `T::MAX.ilog10()`. This works because `ilog10` is a monotonically nondecreasing function, the maximum return value is reached at the max input value.
Tidying up tests/ui/issues tests [3/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge. part of rust-lang#133895 r? Kivooeo
Move ambient gdb discovery from compiletest to bootstrap - Follow-up to rust-lang#148099 --- This code takes the compiletest code for discovering an “ambient” `gdb` in the user's path, and moves it to bootstrap. One of the eventual goals is to allow compiletest to assume that if it has been asked to run the debuginfo-gdb suite, then it *must* have been passed an explicit `--gdb`, though we aren't quite there yet. r? jieyouxu
Check associated type where-clauses for lifetimes resolves: rust-lang#148627 resolves: rust-lang#149233
…mpound-statements, r=jieyouxu contracts: fix lowering final declaration without trailing semicolon Lowering for contract delcarations introduced in rust-lang#144444 incorrectly handled the final declaration statement when it didn't end in a semicolon. This change fixes the issue. See the included regression test for the minimal reproducible example. Contracts tracking issue: rust-lang#128044
…warning-in-tests, r=Kivooeo,jieyouxu contracts: clean up feature flag warning duplicated across tests There is no need for every contracts test to assert the same warning for using the `contracts` feature flag, as such use `#![expect(incomplete_features)]` in the tests, and add one test to specifically check for the warning. Making this change has been discussed in the comments of rust-lang#149722. Contracts tracking issue: rust-lang#128044 r? Kivooeo
…ivooeo mailmap: add binarycat
rustbot
added
A-compiletest
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 |
Collaborator
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 554952348a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5549523 (parent) -> 03d7ad7 (this PR) Test differencesShow 1488 test diffsStage 1
Stage 2
Additionally, 1436 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 03d7ad7dd67d71f1ef1a790fcb4ceb2484ced761 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (03d7ad7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -1.1%, secondary -3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 471.938s -> 472.922s (0.21%) |
Member
|
@rust-timer build 6331671 Doing a perf.run just to test two collectors in rustc-perf. |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ilog10result range hints #149207 (Addilog10result range hints)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup