Move ambient gdb discovery from compiletest to bootstrap #149710
+54
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Member
Author
|
@bors try jobs=arm-android,x86_64-mingw-1,test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 6, 2025
Move ambient gdb discovery from compiletest to bootstrap try-job: arm-android try-job: x86_64-mingw-1 try-job: test-various
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
Member
Author
|
@bors try jobs=arm-android,x86_64-mingw-1,test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 6, 2025
Move ambient gdb discovery from compiletest to bootstrap try-job: arm-android try-job: x86_64-mingw-1 try-job: test-various
|
💔 Test for 8f3e014 failed: CI. Failed jobs:
|
Member
Author
|
Hmm, I had been operating on the assumption that these Android flags were specific to debuginfo, but I guess that’s not the case. @rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
While some of this information is needed by debugger discovery, it is also needed by non-debuginfo tests, so the code doesn't belong in the `debuggers` module.
Member
Author
|
@bors try jobs=arm-android,x86_64-mingw-1,test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 7, 2025
Move ambient gdb discovery from compiletest to bootstrap try-job: arm-android try-job: x86_64-mingw-1 try-job: test-various
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Dec 7, 2025
Comment on lines
+24
to
+25
| // Otherwise, fall back to whatever gdb is sitting around in PATH. | ||
| // (That's the historical behavior, but maybe we should require opt-in?) |
Member
There was a problem hiding this comment.
Remark: I'm 100% in favor of opt-in, but that's a separate change.
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 8, 2025
Move ambient gdb discovery from compiletest to bootstrap - Follow-up to rust-lang#148099 --- This code takes the compiletest code for discovering an “ambient” `gdb` in the user's path, and moves it to bootstrap. One of the eventual goals is to allow compiletest to assume that if it has been asked to run the debuginfo-gdb suite, then it *must* have been passed an explicit `--gdb`, though we aren't quite there yet. r? jieyouxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code takes the compiletest code for discovering an “ambient”
gdbin the user's path, and moves it to bootstrap.One of the eventual goals is to allow compiletest to assume that if it has been asked to run the debuginfo-gdb suite, then it must have been passed an explicit
--gdb, though we aren't quite there yet.r? jieyouxu