Skip to content

Fix gem which command test isolation #9222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afurm wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −1
Open

Fix gem which command test isolation #9222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion test/rubygems/test_gem_commands_which_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,13 @@ def test_execute_directory
end

def test_execute_one_missing
# TODO: this test fails in isolation
original_gem_home = ENV["GEM_HOME"]
original_gem_path = ENV["GEM_PATH"]

ENV["GEM_HOME"] = @gemhome
ENV["GEM_PATH"] = @gemhome
Gem.use_paths(@gemhome)
Gem::Specification.reset

util_foo_bar

Expand All @@ -53,6 +59,21 @@ def test_execute_one_missing
assert_equal "#{@foo_bar.full_gem_path}/lib/foo_bar.rb\n", @ui.output
assert_match(/Can.t find Ruby library file or shared library missinglib\n/,
@ui.error)
ensure
if original_gem_home
ENV["GEM_HOME"] = original_gem_home
else
ENV.delete("GEM_HOME")
end

if original_gem_path
ENV["GEM_PATH"] = original_gem_path
else
ENV.delete("GEM_PATH")
end

Gem.use_paths(@gemhome)
Gem::Specification.reset
end

def test_execute_missing
Expand Down