Fix gem which command test isolation #9222
Open
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afurm
force-pushed
the
fix-which-command-test-isolation
branch
from
55c51d4 to
bf8c2a3
Compare
afurm
force-pushed
the
fix-which-command-test-isolation
branch
from
bf8c2a3 to
0420c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
gem whichcommand reports the filesystem path for a requireable file;test_execute_one_missingverifies it prints the found path and errors on a missing file. The test fails when run in isolation because it relies on gem path/spec state set by other tests.Fix
Set
GEM_HOME/GEM_PATHto@gemhome, callGem.use_paths(@gemhome), and reset the spec cache before the test runs. Restore the env and gem paths in an ensure block and reset the spec cache afterward.Testing
ruby -Ilib:test:bundler/lib test/rubygems/test_gem_commands_which_command.rb -n test_execute_one_missing