-
Notifications
You must be signed in to change notification settings - Fork 11
PMM-14577 Remove Grafana and Grafana SDK from dependencies. #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,137 @@ | |||
| // Copyright 2023 Percona LLC | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code copy out from Grafana code.
| @@ -0,0 +1,64 @@ | |||
| // Copyright 2023 Percona LLC | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code copy out from Grafana code.
| @@ -0,0 +1,88 @@ | |||
| // Copyright 2023 Percona LLC | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code copy out from Grafana code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeahh this is one part i wasn't sure of too (since grafana has its own license)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think any other will trigger lint error. But good point. We can verify this on tomorrow's Go Backend meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we can't change the license, so let's do the following:
- Keep the original license
- Exclude the whole directory from our license linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let's reference the sources so that we can sync up with upstream as necessary.
|
@svetasmirnova Snyk has been deprecated by IT. Shall we remove the related workflows? |
|
@ademidoff Yes. |
PMM-14577
Remove the Grafana and Grafana SDK dependencies (those are causing most of CVEs). I initially asked AI to create the PR and then made the necessary fixes on top of it.
Everything is passing, so it looks good.
PR to main: #350