Enable QAN after 3.5.0 pmm #349
Conversation
| PMM_AGENT_CONFIG_FILE=./setup/pmm/agent.yaml | ||
| PMM_DUMP_PASS="" | ||
| PMM_DUMP_PASS_FILEPATH="" | ||
| PMM_INTERNAL_QAN=1 # The default value is 0 |
There was a problem hiding this comment.
It missing empty line
There was a problem hiding this comment.
Also there is typo. It should be: PMM_ENABLE_INTERNAL_PG_QAN. Like on other places
|
The test is still failing, so it’s probably not passing the variable properly. I’ll take a look. |
Hello @JiriCtvrtka, and thank you! Two tests are failing, the dashboard one has been fixed by your PR (#345). I tested this by merging your PR into the main branch and running the tests. However, I don't understand why it is going into the v3 branch instead of the main branch. The second test is fails with the error: " version_test.go:53: failed to deploy: failed to create pmm server: failed to create container: failed to create container: Error response from daemon: No such image: perconalab/pmm-server:3.2.0". |
|
@Pepsiqqq, we are using the v3 branch for everything related to PMM 3, as PMM 2 is no longer supported. I noticed a difference between main and v3 regarding the images; one uses percona and the other uses perconalab. This was originally introduced in this PR along with several other changes. I need to verify with the rest of the PMM team why everything from that PR wasn't merged into main previously. I'll check with them once they are back. In the meantime, I’ve created a version of my PR for main here: #350 |
2 participants
No description provided.