Skip to content

[release-4.15] OCPBUGS-32399: Update devfile library to v2.2.2 #13762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Apr 20, 2024
Merged

[release-4.15] OCPBUGS-32399: Update devfile library to v2.2.2 #13762

openshift-merge-bot merged 2 commits into from
Apr 20, 2024

Conversation

@maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Apr 16, 2024

Backport of #13045

@maysunfaisal
Update devfile/library go module
de59bcf 
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal
Updated go mod vendor pkg
f89d79e 
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@openshift-ci openshift-ci bot requested review from florkbr and rhamilto April 16, 2024 18:31
@openshift-ci openshift-ci bot added the component/backend Related to backend label Apr 16, 2024
Lucifergene
Lucifergene reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@Lucifergene Lucifergene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@sanketpathak
Copy link
Contributor

sanketpathak commented Apr 17, 2024

Tested on cluster bot, devfile creation is working fine
Screenshot 2024-04-17 at 7 33 21 PM

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 17, 2024
@maysunfaisal
Copy link
Member Author

maysunfaisal commented Apr 17, 2024

/retest

@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Apr 18, 2024

/retest
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 18, 2024
@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Apr 18, 2024

/retitle [release-4.15] OCPBUGS-32399: Update devfile library to v2.2.2

@openshift-ci openshift-ci bot changed the title [release-4.15] Update devfile library to v2.2.2 [release-4.15] OCPBUGS-32399: Update devfile library to v2.2.2 Apr 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2024

@maysunfaisal: This pull request references Jira Issue OCPBUGS-32399, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-32399 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of #13045

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Apr 18, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2024

@jerolimov: This pull request references Jira Issue OCPBUGS-32399, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32398 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Apr 18, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2024

@jerolimov: This pull request references Jira Issue OCPBUGS-32399, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-32398 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32398 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sanketpathak April 18, 2024 08:11
christoph-jerolimov
christoph-jerolimov approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, Lucifergene, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2024

/retest-required

Remaining retests: 0 against base HEAD 52a0104 and 2 for PR HEAD f89d79e in total

@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Apr 20, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2024

@maysunfaisal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d74a877 into openshift:release-4.15 Apr 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2024

@maysunfaisal: Jira Issue OCPBUGS-32399: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32399 has been moved to the MODIFIED state.

Details

In response to this:

Backport of #13045

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 20, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202404200743.p0.gd74a877.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 21, 2024

Fix included in accepted release 4.15.0-0.nightly-2024-04-20-232413

@maysunfaisal maysunfaisal mentioned this pull request Apr 22, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florkbr florkbr Awaiting requested review from florkbr

@rhamilto rhamilto Awaiting requested review from rhamilto

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

2 more reviewers

@Lucifergene Lucifergene Lucifergene left review comments

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@juzhao juzhao

@Lucifergene Lucifergene

@The-Anton The-Anton

@lihongyan1 lihongyan1

@Tai-RedHat Tai-RedHat

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/backend Related to backend jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.