Skip to content

fixed bad REST api URL added PY3 support #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edenbaus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed bad REST api URL added PY3 support #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions crpapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,17 @@
The CRP API (http://www.opensecrets.org/action/api_doc.php) provides campaign
finance and other data from the Center for Responsive Politics.

See README.rst for methods and usage
See README.md for methods and usage
"""

__author__ = "James Turk (jturk@sunlightfoundation.com)"
__version__ = "0.1.0"
__copyright__ = "Copyright (c) 2009 Sunlight Labs"
__license__ = "BSD"

import urllib, urllib2
try:
import json
except ImportError:
import simplejson as json
import urllib
import json
import requests

class CRPApiError(Exception):
""" Exception for CRP API errors """
Expand All @@ -36,16 +34,14 @@ class CRP(object):
def _apicall(func, params):
if CRP.apikey is None:
raise CRPApiError('Missing CRP apikey')

url = 'http://api.opensecrets.org/?method=%s&output=json&apikey=%s&%s' % \
(func, CRP.apikey, urllib.urlencode(params))
url = f"http://www.opensecrets.org/api/?method={func}&output=json%apikey={CRP.apikey}&{urllib.parse.urlencode(params)}"

try:
response = urllib2.urlopen(url).read()
response = requests.get(url).content
return json.loads(response)['response']
except urllib2.HTTPError, e:
except (urllib2.HTTPError, e):
raise CRPApiError(e.read())
except (ValueError, KeyError), e:
except ((ValueError, KeyError), e):
raise CRPApiError('Invalid Response')

class getLegislators(object):
Expand Down Expand Up @@ -106,4 +102,4 @@ class congCmteIndus(object):
@staticmethod
def get(**kwargs):
results = CRP._apicall('congCmteIndus', kwargs)['committee']['member']
return results
return results