fixed bad REST api URL added PY3 support #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenbaus
commented
Apr 4, 2019
edenbaus
commented
- Changed docstring to point to README.md not README.rst
- wrapped exception tuples in parenthesis
- use f string to create url
- switch to requests library to open url
- change urllib2 to urllib
- Changed docstring to point to README.md not README.rst - wrapped exception tuples in parenthesis - use f string to create url - switch to requests library to open url - change urllib2 to urllib
|
@edenbaus probably want to add a header w/User-Agent to the new requests code now that Open Secrets is currently preventing generic user agents from scraping their site (will result in |
Author
|
@mdublin Good suggestion. I’ll update the pull request with the relevant header/user agent code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.