Skip to content

Updating i18n management (2025 best practices) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaferMazu merged 3 commits into from
Aug 4, 2025
Merged

Updating i18n management (2025 best practices) #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03680e9
chore: ignoring the build directory
felipemontoya Aug 4, 2025
6442832
fix: QA reported an automatic translations error
felipemontoya Aug 4, 2025
103393f
chore: updating i18n management to 2025 standards
felipemontoya Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ phpcs-report.xml
build
.DS_Store
source/.DS_Store

### Build files ###
openedx-commerce
42 changes: 0 additions & 42 deletions includes/class-openedx-commerce-i18n.php
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions includes/class-openedx-commerce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ public function __construct() {
$this->plugin_name = 'openedx-commerce';

$this->load_dependencies();
$this->set_locale();
$this->define_admin_hooks();
$this->define_public_hooks();
$this->define_plugin_settings_hooks();
Expand All @@ -84,7 +83,6 @@ public function __construct() {
* Include the following files that make up the plugin:
*
* - Openedx_Commerce_Loader. Orchestrates the hooks of the plugin.
* - Openedx_Commerce_I18n. Defines internationalization functionality.
* - Openedx_Commerce_Admin. Defines all hooks for the admin area.
* - Openedx_Commerce_Public. Defines all hooks for the public side of the site.
*
Expand All @@ -103,13 +101,6 @@ private function load_dependencies() {
include_once plugin_dir_path( __DIR__ )
. 'includes/class-openedx-commerce-loader.php';

/**
* The class responsible for defining internationalization functionality
* of the plugin.
*/
include_once plugin_dir_path( __DIR__ )
. 'includes/class-openedx-commerce-i18n.php';

/**
* The class responsible for defining all actions that occur in the admin area.
*/
Expand Down Expand Up @@ -170,26 +161,6 @@ private function load_dependencies() {
. 'includes/model/class-openedx-commerce-api-calls.php';
}

/**
* Define the locale for this plugin for internationalization.
*
* Uses the Openedx_Commerce_I18n class in order to set the domain and to register the hook
* with WordPress.
*
* @since 1.0.0
* @access private
*/
private function set_locale() {

$plugin_i18n = new Openedx_Commerce_I18n();

$this->loader->add_action(
'plugins_loaded',
$plugin_i18n,
'load_plugin_textdomain'
);
}

/**
* Register all of the hooks related to the admin area functionality
* of the plugin.
Expand Down