Updating i18n management (2025 best practices)

[felipemontoya]

Description

During testing of a different PR, I noticed that there is something failing with the CI. So I opened this new PR to see if this happening in main and fix it in a separate environment.

This PR then removew Openedx_Commerce_I18n, its instantiation, and every reference to load_plugin_textdomain() to simplify our codebase, eliminate the CI failure, and bring the plugin in line with current WordPress best practice.

Testing instructions

Let the CI run and if fixed, you should see all green checks.

Additional information

WordPress has handled plugin translations automatically since version 4.6 (August 2016) via its just-in-time loader: the first time a string with our openedx-commerce text-domain is encountered, core looks in both the site-wide wp-content/languages/plugins/ directory and the plugin’s own /languages folder, then loads the matching .mo/.json file. Because of that, explicitly calling load_plugin_textdomain() is now considered redundant—so much so that the official Plugin Check sniffs flag any static reference to it as a blocking error.

Checklist for Merge

• CI working
• tested on remote

[openedx-webhooks]

Thanks for the pull request, @felipemontoya!

This repository is currently maintained by @mafermazu.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[felipemontoya]

More info at

• https://make.wordpress.org/core/2024/10/21/i18n-improvements-6-7/
• Check: Using load_plugin_textdomain() for loading the plugin translations is not needed for WordPress.org directory since WordPress 4.6 WordPress/plugin-check#909

[MaferMazu]

I tested in a local and remote environment, and it works as expected!

Thanks for the contribution 🙌