fix(cache): regenerate stream from source when cache.match is called after GC #4713
+72
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The bug occurs due to the interaction between the
FinalizationRegistry(used to track Response objects) and thecloneBody()function which mutates the original body's stream in-place:cache.match()callsfromInnerResponse()which creates a temporary Response and registers the cached streamresponse.clone()is called, which tees the stream and mutates the cached stream to be one of the tee outputsclone()re-registers this mutated stream with the temporary Responsecache.match()calls failFix
The fix checks if the cached stream is unusable but
body.sourceis available (whichcache.put()always stores after reading the body bytes), and recreates the stream from source before creating the Response object.Fixes: #4710
Test plan
🤖 Generated with Claude Code