Skip to content

Make loops work on web #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sertony wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make loops work on web #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2303a7f
make loops work on web
sertony Nov 27, 2020
a8186a5
update build.gradle
sertony Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@

buildscript {
ext {
buildToolsVersion = "28.0.3"
minSdkVersion = 16
compileSdkVersion = 28
targetSdkVersion = 28
buildToolsVersion = "30.0.2"
minSdkVersion = 21
compileSdkVersion = 30
targetSdkVersion = 30
}
repositories {
google()
jcenter()
mavenCentral()
}
dependencies {
classpath("com.android.tools.build:gradle:3.4.2")
classpath("com.android.tools.build:gradle:4.2.2")

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
Expand All @@ -32,7 +32,7 @@ allprojects {
}

google()
jcenter()
mavenCentral()
maven { url 'https://jitpack.io' }
}
}
4 changes: 2 additions & 2 deletions src/components/indicator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React, { PureComponent } from 'react';
import { Animated, Easing } from 'react-native';
import { Animated, Easing, Platform } from 'react-native';

export default class Indicator extends PureComponent {
static defaultProps = {
Expand Down Expand Up @@ -94,7 +94,7 @@ export default class Indicator extends PureComponent {
.timing(progress, {
duration: animationDuration,
easing: animationEasing,
useNativeDriver: true,
useNativeDriver: Platform.OS !== 'web', // Web doesn't support loops if using Native Driver
isInteraction: interaction,
toValue: 1,
});
Expand Down