Make loops work on web #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @n4kz , can you please check this PR? |
|
@n4kz Could you merge this and/or give somebody else access to help review and pull requests by any chance? |
|
Hey, can we move this forward? The solution seems good, what's the hold up? |
|
@n4kz please this is blocking many people, fix this MR 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
react-native-indicatordoesn't work withreact-native-webdue to the fact that_startNativeLoopimplementation on web is not working due to the missingNativeAnimatedModulefor web:https://github.com/necolas/react-native-web/blob/a877a02beb6a2032430f83b062e173d68c40c65d/packages/react-native-web/src/vendor/react-native/Animated/NativeAnimatedHelper.js#L266
That's why the only way to make it work on web is to turn off the native driver and switch to recursive calls on JS thread:
https://github.com/necolas/react-native-web/blob/a877a02beb6a2032430f83b062e173d68c40c65d/packages/react-native-web/src/vendor/react-native/Animated/AnimatedImplementation.js#L452