Skip to content

fix: SDKE-360 create defensive copies of strings for completion callback parameters #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
denischilik merged 2 commits into from
Oct 10, 2025
Merged

fix: SDKE-360 create defensive copies of strings for completion callback parameters #27

denischilik merged 2 commits into from
Oct 10, 2025

Conversation

@denischilik
Copy link
Contributor

@denischilik denischilik commented Oct 10, 2025 •
edited
Loading

Summary

  • copy attributes to prevent potential releasing them from the memory
  • fix parameter order in definition

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

nickolas-dimitrakas
nickolas-dimitrakas approved these changes Oct 10, 2025
View reviewed changes
Copy link

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, went over in call

@rmi22186 rmi22186 mentioned this pull request Oct 10, 2025
Closed
1 task
@rmi22186
Copy link

rmi22186 commented Oct 10, 2025

why is there a PR here also? #26

@denischilik
Copy link
Contributor Author

denischilik commented Oct 10, 2025

why is there a PR here also? #26

previous used wrong brach name fixed it to be consistent

@denischilik denischilik changed the title fix: SDKE-360 ULTA Crash fix: SDKE-360 fix: create defensive copies of strings for completion callback parameters Oct 10, 2025
@denischilik denischilik merged commit 18f3342 into development Oct 10, 2025
5 of 6 checks passed
@denischilik denischilik changed the title fix: SDKE-360 fix: create defensive copies of strings for completion callback parameters fix: SDKE-360 create defensive copies of strings for completion callback parameters Oct 10, 2025
@denischilik
Copy link
Contributor Author

denischilik commented Oct 10, 2025

why is there a PR here also? #26

update a branch name as proposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickolas-dimitrakas nickolas-dimitrakas nickolas-dimitrakas approved these changes

@thomson-t thomson-t Awaiting requested review from thomson-t

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@denischilik @rmi22186 @nickolas-dimitrakas