Skip to content

Conversation

@denischilik
Copy link
Contributor

Summary

  • copy attributes to prevent potential releasing them from the memory
  • fix parameter order in definitio

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@rmi22186
Copy link

why is this PR duplicated - #27

@rmi22186
Copy link

Please update PR title to be something like fix: create defensive copies of strings for completion callback parameters

1 similar comment
@rmi22186
Copy link

Please update PR title to be something like fix: create defensive copies of strings for completion callback parameters

Copy link

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update commit title

Copy link

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update commit title

@denischilik
Copy link
Contributor Author

closed because of wrong branch name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants