Support asynchronous abilities #182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anehx rebase and 🆙 🙃 |
anehx
force-pushed
the
async-abilities
branch
from
1755f0f to
92df819
Compare
Author
|
@RobbieTheWagner Is this a feature you'd consider? |
Collaborator
In general, I think I would support this. I think we should make the default helpers this addon ships handle both async and sync though and not require another dependency, if possible. |
Author
|
@RobbieTheWagner Sure, that would be possible. However, I explicitly didn't do that as we then would have to decide on what it resolves to if the promise is still pending. IMO the least incorrect way would be to resolve to What do you think? I'd be happy to invest some time into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in multiple issues (#160, #20),
ember-cancurrently doesn't support async abilities. This seems to be an issue for a lot of its users as it is a real use-case that permissions are evaluated with e.g. a call to an API.This PR would support async abilities without changing the current API at all. The only thing required for it to work in templates would be
ember-promise-helpersto handle the promises in the templates.This solution is currently running in one of my projects and works pretty good. Please let me know if you are interested in this. If this is a viable solution, we could also look into changing the template helpers so they can handle the promises itself in order to drop the necessary dependency.