Skip to content

Conversation

@c0rydoras
Copy link
Collaborator

@c0rydoras c0rydoras commented Aug 8, 2025

currently broken because of issues with ember-responsive ingested into timed repo
currently broken because of ember-can hacked around via adfinis/ember-can@c95e863

@c0rydoras c0rydoras force-pushed the fix/frontend/ember-6.4 branch 3 times, most recently from 80853ee to 982de94 Compare August 11, 2025 08:44
@c0rydoras c0rydoras marked this pull request as ready for review August 11, 2025 08:50
@c0rydoras c0rydoras requested a review from a team as a code owner August 11, 2025 08:50
@c0rydoras c0rydoras force-pushed the fix/frontend/ember-6.4 branch 2 times, most recently from 0245929 to cee77b5 Compare August 11, 2025 08:55
@c0rydoras c0rydoras requested a review from derrabauke August 11, 2025 09:07
@c0rydoras c0rydoras force-pushed the fix/frontend/ember-6.4 branch 3 times, most recently from 36a9e34 to d2910f0 Compare August 13, 2025 08:17
@derrabauke
Copy link
Member

Don't you think it's worth forking the ember-responsive package under our namespace? We use it in other projects as well 🤷‍♂️
The transfer of the project to ember adopted addons doesn't seem to proceed...

Another dev also forked it and made it ember v6 compatible in his fork

@derrabauke
Copy link
Member

Regarding the ember-can/resolver issue, would it make sense to open an upstream PR with those changes? Looks like this has to get fixed there anyways. For now using your fork is 🆗 , but fixing it there would let other people profit from it as well.

@c0rydoras
Copy link
Collaborator Author

regarding ember-can, i copied those changes from the upstream and applied them to minutebase/ember-can#182 (which we need for ember data > 4.12)

@c0rydoras
Copy link
Collaborator Author

It would make sense to move the fork into the @adfinis namespace

@c0rydoras
Copy link
Collaborator Author

c0rydoras commented Nov 14, 2025

Don't you think it's worth forking the ember-responsive package under our namespace? We use it in other projects as well 🤷‍♂️

Would probably be worth it, even tho instead of forking, starting from scratch (v2 addon template) would probably be easier (given its only 2 files)

@c0rydoras c0rydoras force-pushed the fix/frontend/ember-6.4 branch from d2910f0 to 54becf2 Compare November 14, 2025 09:20
@derrabauke
Copy link
Member

Don't you think it's worth forking the ember-responsive package under our namespace? We use it in other projects as well 🤷‍♂️

Would probably be worth it, even tho instead of forking, starting from scratch (v2 addon template) would probably be easier (given its only 2 files)

Reasonable. But let's link+mention the original addon (MIT license)

@c0rydoras c0rydoras force-pushed the fix/frontend/ember-6.4 branch from 54becf2 to 1c18de4 Compare November 14, 2025 12:17
Copy link
Member

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe though we gonna fork ember-responsive, but ok for me for the moment like it is. Next run.

@c0rydoras c0rydoras merged commit a2e6de4 into adfinis:main Nov 17, 2025
7 checks passed
@c0rydoras c0rydoras deleted the fix/frontend/ember-6.4 branch November 17, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants