-
Notifications
You must be signed in to change notification settings - Fork 9
frontend: ember 6.4 #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: ember 6.4 #841
Conversation
80853ee to
982de94
Compare
0245929 to
cee77b5
Compare
36a9e34 to
d2910f0
Compare
|
Don't you think it's worth forking the Another dev also forked it and made it ember v6 compatible in his fork |
|
Regarding the ember-can/resolver issue, would it make sense to open an upstream PR with those changes? Looks like this has to get fixed there anyways. For now using your fork is 🆗 , but fixing it there would let other people profit from it as well. |
|
regarding |
|
It would make sense to move the fork into the @adfinis namespace |
Would probably be worth it, even tho instead of forking, starting from scratch (v2 addon template) would probably be easier (given its only 2 files) |
d2910f0 to
54becf2
Compare
Reasonable. But let's link+mention the original addon (MIT license) |
54becf2 to
1c18de4
Compare
derrabauke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe though we gonna fork ember-responsive, but ok for me for the moment like it is. Next run.
currently broken because of issues with ember-responsiveingested into timed repocurrently broken because of ember-canhacked around via adfinis/ember-can@c95e863