Skip to content

added a $watch for vm.value #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mertpamukcu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added a $watch for vm.value #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/angular-selectbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,12 @@

$scope.$on('$destroy', _unbind);

$scope.$watch('vm.value',function(){
// watches value changes from external locations.
// Useful for working with socket.io
_getSelected();
Copy link

@myershov myershov Jul 27, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milica, thank you for your job!
I have found similar bug in my apps, and that solution resolve my problem.
@mertpamukcu, great that you found it;
But we have one more problem;
We need to delete additional call
_getSelected();
From function 'change' at line 177, because it will be called from watch; Avoided double call.

});

/**
* Get selected object
*
Expand Down