added a $watch for vm.value #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $scope.$watch('vm.value',function(){ | ||
| // watches value changes from external locations. | ||
| // Useful for working with socket.io | ||
| _getSelected(); |
There was a problem hiding this comment.
@milica, thank you for your job!
I have found similar bug in my apps, and that solution resolve my problem.
@mertpamukcu, great that you found it;
But we have one more problem;
We need to delete additional call
_getSelected();
From function 'change' at line 177, because it will be called from watch; Avoided double call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just wanted to share my commit for make this selectbox works with external changes on selected value. Please update if there is a better way.