Small Improvements?

dist/common/types.d.ts

@@ -1,8 +1,20 @@
 export type TellerOptionsBase = {
     accessToken: string;
 };
+/**
+ * Using the latest Teller Version: 2020-10-12
+ */
 export type TellerOptionsPagination = TellerOptionsBase & {
-    cursor: string;
-    limit: number;
+    /**
+     * The maximum number of transactions to return in the API response.
+     */
+    count?: number;
+    /**
+     * The transaction from where to start the page.
+     * The first transaction in the API response will be the one immediately before the transaction in the ledger with this id.
+     *
+     * example: txn_oiluj93igokseo0i3a005
+     */
+    from_id?: string;
 };
 //# sourceMappingURL=types.d.ts.map

package.json

@@ -1,6 +1,6 @@
 {
-  "name": "teller",
-  "version": "0.1.0",
+  "name": "node-teller",
+  "version": "0.1.5",
   "description": "teller.io API client for nodejs",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

src/common/types.ts

@@ -1,8 +1,20 @@
 export type TellerOptionsBase = {
   accessToken: string;
-}
+};
 
+/**
+ * Using the latest Teller Version: 2020-10-12
+ */
 export type TellerOptionsPagination = TellerOptionsBase & {
-  cursor: string;
-  limit: number;
-}
+  /**
+   * The maximum number of transactions to return in the API response.
+   */
+  count?: number;
+  /**
+   * The transaction from where to start the page.
+   * The first transaction in the API response will be the one immediately before the transaction in the ledger with this id.
+   *
+   * example: txn_oiluj93igokseo0i3a005
+   */
+  from_id?: string;
+};

src/modules/transaction.ts

@@ -5,15 +5,14 @@ import type { TellerTransaction } from "../interfaces/transaction.js";
 export default class TellerTransactionModule extends ClientBase {
   async list(
     accountId: string,
-    options?: TellerOptionsPagination,
+    options?: TellerOptionsPagination
   ): Promise<TellerTransaction[]> {
-    const searchParams =
-      options?.cursor && typeof options?.limit === "number"
-        ? new URLSearchParams({
-            from_id: options?.cursor,
-            count: options?.limit?.toString(),
-          }).toString()
-        : null;
+    const params = Object.entries({
+      count: options?.count?.toString(),
+      from_id: options?.from_id,
+    }).filter((entry): entry is [string, string] => entry[1] != null);
+
+    const searchParams = new URLSearchParams(params);
 
     const response = await this.axios.get(
       `/accounts/${accountId}/transactions?${searchParams}`,
@@ -22,7 +21,7 @@ export default class TellerTransactionModule extends ClientBase {
           ? { username: options.accessToken, password: "" }
           : undefined,
         responseType: "json",
-      },
+      }
     );
 
     if (typeof response.data === "string") {
@@ -34,7 +33,7 @@ export default class TellerTransactionModule extends ClientBase {
 
   async get(
     { accountId, id }: { id: string; accountId: string },
-    options?: TellerOptionsPagination,
+    options?: TellerOptionsPagination
   ): Promise<TellerTransaction> {
     const response = await this.axios.get(
       `/accounts/${accountId}/transactions/${id}`,
@@ -43,7 +42,7 @@ export default class TellerTransactionModule extends ClientBase {
           ? { username: options.accessToken, password: "" }
           : undefined,
         responseType: "json",
-      },
+      }
     );
 
     if (typeof response.data === "string") {