Small Improvements? #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @MattGould1 for making the contribution |
KingkorAtMaxint
requested changes
Jan 23, 2025
Comment on lines
+8
to
+18
| /** | ||
| * The maximum number of transactions to return in the API response. | ||
| */ | ||
| count?: number; | ||
| /** | ||
| * The transaction from where to start the page. | ||
| * The first transaction in the API response will be the one immediately before the transaction in the ledger with this id. | ||
| * | ||
| * example: txn_oiluj93igokseo0i3a005 | ||
| */ | ||
| from_id?: string; |
Contributor
There was a problem hiding this comment.
The doc comments are nice but there's no need for a renaming of the options here. cursor and limit are just generalized term for count and from_id understood by everyone. We don't want unnecessary changes here.
So please revert the name changes everywhere in the PR
But the doc comments are a nice addition.
| "name": "teller", | ||
| "version": "0.1.0", | ||
| "name": "node-teller", | ||
| "version": "0.1.5", |
Contributor
There was a problem hiding this comment.
Why does it require a version change? Also even if so, it should be 0.1.1 why 0.1.5?
Comment on lines
+9
to
+20
| /** | ||
| * The maximum number of transactions to return in the API response. | ||
| */ | ||
| count?: number; | ||
| /** | ||
| * The transaction from where to start the page. | ||
| * The first transaction in the API response will be the one immediately before the transaction in the ledger with this id. | ||
| * | ||
| * example: txn_oiluj93igokseo0i3a005 | ||
| */ | ||
| from_id?: string; | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Couple of bits here (some might not be improvements based on whether this package is being used currently).
TellerOptionsPaginationto use the same param keys as the Teller IO document, see https://teller.io/docs/api/account/transactions#list-transactionslisttransactions and allow optionalcountor optionalfrom_idAlso, I actually published this package to NPM because I needed it for a different task. If you want to publish it from maxint, i'll go ahead and remove my NPM package