-
Notifications
You must be signed in to change notification settings - Fork 13
Provide redirect and token Firebase functions to allow OSM log in for MapSwipe web #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenhelium
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapSwipe app allows for authentication through OpenStreetMap OAuth2 for a while already, the MapSwipe web application lacks this feature so far.
Two different Firebase functions (
redirectandtoken) are currently provided to enable OSM authentication for the smartphone app. This PR provides the additional two respective Firebase functionsredirectwebandtokenwebto allow for OSM authentication through the web app.The additional functions work pretty much the same as the existing ones, but use a different OSM OAuth client with a different redirect link. This is necessary, as the redirect URL has to be the same as the one defined for the OSM OAuth client.
In addition to that, this PR includes a fix to an existing bug to avoid that OSM authenticated profiles are overwritten on Firebase RTDB with each new log in.
Prerequisites
This introduces four new .env variables that need to be set:
https://auth.mapswipe.org/tokenweb(https://dev-auth.mapswipe.org/tokenwebfor the dev instance)tokenweb. Should behttps://web.mapswipe.org/#/osm-callback(https://web.mapswipe.org/dev/#/osm-callbackfor MapSwipe dev instance)Deployment
To properly deploy the updated functions on the server, make sure to remove the firebase_deploy image first:
Test
OSM_OAUTH_APP_LOGIN_LINK_WEB='http://localhost:5173/#/osm-callback'for testing purposesFixes #1030