17 enhancement add the ability to sign in using an osm account #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing-an-osm-account
ofr1tz
deleted the
17-enhancement-add-the-ability-to-sign-in-using-an-osm-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables signing in to MapSwipe web application with an OSM account, as is possible with the smartphone app for a while already.
In order to work properly, this implementation depends on mapswipe/python-mapswipe-workers#1031 being deployed.
The PR introduces a new environment variable
VITE_OSM_OAUTH_REDIRECT_URIwhich should be set tohttps://auth.mapswipe.org/redirectweborhttps://dev-auth.mapswipe.org/redirectwebfor the dev instance respectively. If the variable is not set, the OSM sign in component will be hidden from the user.