Skip to content

Allow user attributes with empty string values to be set #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmustafa-tse wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow user attributes with empty string values to be set #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mParticle-Apple-SDK/Identity/MParticleUser.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ - (nullable NSNumber *)incrementUserAttribute:(NSString *)key byValue:(NSNumber
- (void)setUserAttribute:(nonnull NSString *)key value:(nonnull id)value {
[MPListenerController.sharedInstance onAPICalled:_cmd parameter1:key parameter2:value];

if ([value isKindOfClass:[NSString class]] && (((NSString *)value).length <= 0)) {
if ([value isKindOfClass:[NSString class]] && (((NSString *)value).length < 0)) {
Copy link
Contributor

@denischilik denischilik Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this check (((NSString *)value).length < 0) can be removed at all because length can't be negative

MPILogDebug(@"User attribute not updated. Please use removeUserAttribute.");

return;
Expand Down
2 changes: 1 addition & 1 deletion mParticle-Apple-SDK/MPBackendController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2037,7 +2037,7 @@ - (void)setUserAttribute:(NSString *)key value:(id)value timestamp:(NSDate *)tim
return;
}

if (!(([value isKindOfClass:[NSString class]] && ((NSString *)value).length > 0) || [value isKindOfClass:[NSNumber class]]) && value != nil) {
if (!(([value isKindOfClass:[NSString class]] && ((NSString *)value).length >= 0) || [value isKindOfClass:[NSNumber class]]) && value != nil) {
Copy link
Contributor

@denischilik denischilik Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic look strange to me looks like it can be simplified to
if (!( [value isKindOfClass:[NSString class]] || [value isKindOfClass:[NSNumber class]] ))

if (completionHandler) {
completionHandler(keyCopy, value, MPExecStatusInvalidDataType);
}
Expand Down