Allow user attributes with empty string values to be set #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denischilik
reviewed
Oct 15, 2025
| [MPListenerController.sharedInstance onAPICalled:_cmd parameter1:key parameter2:value]; | ||
|
|
||
| if ([value isKindOfClass:[NSString class]] && (((NSString *)value).length <= 0)) { | ||
| if ([value isKindOfClass:[NSString class]] && (((NSString *)value).length < 0)) { |
Contributor
There was a problem hiding this comment.
I think this check (((NSString *)value).length < 0) can be removed at all because length can't be negative
| } | ||
|
|
||
| if (!(([value isKindOfClass:[NSString class]] && ((NSString *)value).length > 0) || [value isKindOfClass:[NSNumber class]]) && value != nil) { | ||
| if (!(([value isKindOfClass:[NSString class]] && ((NSString *)value).length >= 0) || [value isKindOfClass:[NSNumber class]]) && value != nil) { |
Contributor
There was a problem hiding this comment.
This logic look strange to me looks like it can be simplified to
if (!( [value isKindOfClass:[NSString class]] || [value isKindOfClass:[NSNumber class]] ))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A client noticed in their iOS React Native app that user attributes with empty string are not being set. We confirmed that custom feeds, Web SDK and Android SDK (in both original SDK and React Native) are forwarding the attribute as expected when the string is empty. We were able to identify that this issue is on the iOS SDK and not React Native SDK itself when testing. The code here adds the necessary fixes to allow empty string attributes to not be considered an invalid data type and would forward as the same other SDKs.
Testing Plan
Changed the files locally on my sample app in the mParticle iOS SDK and tested with my sample app.