refactor(web): implement token splitting on SearchPath / SearchSpace 🚂 #15023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/manage-true-inputs-on-path
branch
from
f77c477 to
5dd11d5
Compare
jahorton
force-pushed
the
refactor/web/search-path-splitting
branch
from
b741e1d to
a6ccfd0
Compare
jahorton
force-pushed
the
refactor/web/manage-true-inputs-on-path
branch
2 times, most recently
from
564acba to
3ab72c7
Compare
jahorton
force-pushed
the
refactor/web/search-path-splitting
branch
from
347f7ed to
fc97837
Compare
jahorton
changed the base branch from
refactor/web/manage-true-inputs-on-path
to
refactor/web/relocate-source-range-key
jahorton
force-pushed
the
refactor/web/search-path-splitting
branch
from
fc97837 to
2fc98eb
Compare
jahorton
changed the base branch from
refactor/web/relocate-source-range-key
to
refactor/web/rename-and-doc-pending-tokenization
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
461fa4d to
449ebec
Compare
Once we support modeling of multiple paths to construct individual context tokens, it's notably less straightforward to split or merge the correction-search paths on the token level. It's instead wisest to implement this via the SearchSpace interface and its implementing types, which are designed to recursively model all relevant paths and thus can facilitate these operations more directly. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/search-path-splitting
branch
from
2fc98eb to
e6cbc29
Compare
…refactor/web/search-path-splitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While token-splitting is currently implemented on
ContextToken, supporting splits (and merges) for a graph of SearchSpaces that converge and diverge as new keystrokes are added gets really tricky if kept in place. A cleaner way forward is to support.split()(and next, also.merge()) on theSearchSpacetype itself.To facilitate this, a few new additional properties are added to the
SearchSpaceinterface; these exist to exchange information with otherSearchSpaces andSearchSpacetypes as necessary to fully implement.split().Build-bot: skip build:web
Test-bot: skip