refactor(web): implement SourcePath merging 🚂 #15024
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/search-path-splitting
branch
from
b741e1d to
a6ccfd0
Compare
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
3 times, most recently
from
b38ff1b to
bb341f4
Compare
jahorton
force-pushed
the
refactor/web/search-path-splitting
branch
from
347f7ed to
fc97837
Compare
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
from
076bfdc to
bc51029
Compare
jahorton
force-pushed
the
refactor/web/search-path-splitting
branch
from
fc97837 to
2fc98eb
Compare
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
from
bc51029 to
413fdcf
Compare
jahorton
changed the base branch from
refactor/web/search-path-splitting
to
change/web/track-righthand-split-index
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
from
413fdcf to
e9b8e2d
Compare
jahorton
force-pushed
the
change/web/track-righthand-split-index
branch
from
220bf34 to
b51dbc3
Compare
As with the prior PR, this moves correction-search path merging onto SourcePath, rather than expecting ContextToken to manage it when multiple paths to construct a token exists. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
from
e9b8e2d to
9b947b7
Compare
…eb/search-path-merging
…eb/search-path-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with #15023, this moves correction-search path merging onto SourcePath, rather than expecting ContextToken to manage it when multiple paths to construct a token exists.
.merge()will now be defined onSearchSpace.This also adds
SearchSpace.isSameSpace(), a method designed for use in unit-testing at this stage. It will also have practical live applications in #15031. The method is useful for verifying that a pre-built version of the correction-search-space matches what is constructed by merging two separate spaces designed to represent the same total space when merged.Build-bot: skip build:web
Test-bot: skip