-
-
Notifications
You must be signed in to change notification settings - Fork 354
chore(ci): Bump back iOS CI runners to macos-15 #5339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5571058
chore(ci): Bump back iOS CI runners to macos-15
antonis 100b740
Bump xcode version for 0.71.11
antonis f0628ca
Merge branch 'main' into antonis/bump-runners-to-macos-15
antonis 9850b9f
Bump E2E to iOS 15.1
antonis 5879300
Bump xcode to 16.4
antonis 63238e4
Merge branch 'main' into antonis/bump-runners-to-macos-15
antonis 221d0fe
chore(ci): Update hardcoded Xcode 16.2 references to 16.4
antonis 22745f8
chore(ci): Update iOS simulator to iPhone SE (3rd generation) with iO…
antonis 89a09de
Scroll to make button visible
antonis e927b60
Merge branch 'main' into antonis/bump-runners-to-macos-15
antonis b20e610
Extend wait for button
antonis fd80aaa
Revert "Extend wait for button"
antonis 71f9b86
Use iPhone 16
antonis 2a71fc7
Run native tests on iPhone 16 too
antonis 3e00836
Merge branch 'main' into antonis/bump-runners-to-macos-15
antonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,13 +21,16 @@ if (enableHermes === null) { | |
| throw new Error('Invalid engine'); | ||
| } | ||
|
|
||
| // Optional iOS version argument, defaults to '15.1' due to Cocoa SDK V9 and RN 0.81.0 requirement | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was picked from #5369 |
||
| const iosVersion = args['ios-version'] || '15.1'; | ||
|
|
||
| debug.log('Patching Podfile', args['pod-file']); | ||
| const content = fs.readFileSync(args['pod-file'], 'utf8'); | ||
| let content = fs.readFileSync(args['pod-file'], 'utf8'); | ||
|
|
||
| const isHermesEnabled = content.includes(':hermes_enabled => true,'); | ||
| const shouldPatch = enableHermes !== isHermesEnabled; | ||
| if (shouldPatch) { | ||
| const patched = content.replace( | ||
| content = content.replace( | ||
| /:hermes_enabled.*/, | ||
| enableHermes ? ':hermes_enabled => true,' : ':hermes_enabled => false,', | ||
| ); | ||
|
|
@@ -36,7 +39,34 @@ if (shouldPatch) { | |
| } else { | ||
| debug.log('Patching Podfile for JSC'); | ||
| } | ||
| fs.writeFileSync(args['pod-file'], patched); | ||
| } | ||
|
|
||
| // Patch iOS version | ||
| const platformPattern = /platform :ios, (min_ios_version_supported|['"][0-9.]+['"])/; | ||
| const currentMatch = content.match(platformPattern); | ||
|
|
||
| if (currentMatch) { | ||
| const currentValue = currentMatch[1]; | ||
| const shouldPatchVersion = currentValue === 'min_ios_version_supported' || | ||
| currentValue !== `'${iosVersion}'`; | ||
|
|
||
| if (shouldPatchVersion) { | ||
| content = content.replace( | ||
| platformPattern, | ||
| `platform :ios, '${iosVersion}'` | ||
| ); | ||
| debug.log(`Patching iOS version to ${iosVersion} (was: ${currentValue})`); | ||
| } else { | ||
| debug.log(`iOS version already set to ${iosVersion}`); | ||
| } | ||
| } else { | ||
| debug.log('Warning: Could not find platform :ios line to patch'); | ||
| } | ||
|
|
||
| // Write the file if any changes were made | ||
| if (shouldPatch || currentMatch) { | ||
| fs.writeFileSync(args['pod-file'], content); | ||
| debug.log('Podfile patched successfully!'); | ||
| } else { | ||
| debug.log('Podfile is already patched!'); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of leaving this since the device availability seems to change and it will be handy for debugging related failures.