-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update PHP sidenavs to conform with Python and Ruby #15683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| --- | ||
| title: Configuration | ||
| title: Extended Configuration | ||
| sidebar_title: Extended Configuration | ||
| description: "Additional configuration options for the SDK." | ||
| sidebar_order: 5 | ||
| sidebar_order: 2 | ||
| sidebar_section: configuration | ||
| --- | ||
|
|
||
| <PageGrid /> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| --- | ||
| title: Data Management | ||
| description: Manage your events by pre-filtering, scrubbing sensitive information, and forwarding them to other systems. | ||
| sidebar_order: 2500 | ||
| sidebar_order: 4 | ||
| sidebar_section: configuration | ||
| --- | ||
|
|
||
| <PageGrid /> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| --- | ||
| title: Enriching Events | ||
| description: Enrich events with additional context to make debugging simpler. | ||
| sidebar_order: 2300 | ||
| sidebar_order: 1 | ||
| sidebar_section: configuration | ||
| --- | ||
|
|
||
| <PageGrid /> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| --- | ||
| title: Integrations | ||
| description: "Learn about the automatic integrations Sentry provides and how to configure them." | ||
| sidebar_order: 500 | ||
| sidebar_order: 6 | ||
| sidebar_section: features | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Symfony integrations page has wrong sidebar sectionThe Symfony integrations page is assigned |
||
| --- | ||
|
|
||
| ## Default Integrations | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Logs sidebar order contradicts intended navigation sequence
The PR description states the Features section order should be "Capturing Errors → Logs → Tracing → Profiling → Crons", which matches Python's structure where Logs (
sidebar_order: 4) appears before Tracing (sidebar_order: 6). However, the PHP implementation sets Logs tosidebar_order: 4, Tracing tosidebar_order: 2, and Profiling tosidebar_order: 3, resulting in the order "Capturing Errors → Tracing → Profiling → Logs → Crons". To match the stated intent, Logs should besidebar_order: 2, with Tracing and Profiling adjusted accordingly.Additional Locations (1)
docs/platforms/php/guides/laravel/logs/index.mdx#L4-L5