-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update PHP sidenavs to conform with Python and Ruby #15683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 3.1kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
sfanahata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
| description: "Learn about the automatic integrations Sentry provides and how to configure them." | ||
| sidebar_order: 500 | ||
| sidebar_order: 6 | ||
| sidebar_section: features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Symfony integrations page has wrong sidebar section
The Symfony integrations page is assigned sidebar_section: features, but this is inconsistent with the common PHP integrations page which uses sidebar_section: configuration. The PR description also states that "Integrations" belongs in the Configuration section, and the Python platform (which this PR aims to match) also puts Integrations under sidebar_section: configuration. This causes the Symfony integrations page to appear in a different navigation section than intended.
| sidebar_title: Logs | ||
| description: "Structured logs allow you to send, view and query logs sent from your applications within Sentry." | ||
| sidebar_order: 5600 | ||
| sidebar_order: 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Logs sidebar order contradicts intended navigation sequence
The PR description states the Features section order should be "Capturing Errors → Logs → Tracing → Profiling → Crons", which matches Python's structure where Logs (sidebar_order: 4) appears before Tracing (sidebar_order: 6). However, the PHP implementation sets Logs to sidebar_order: 4, Tracing to sidebar_order: 2, and Profiling to sidebar_order: 3, resulting in the order "Capturing Errors → Tracing → Profiling → Logs → Crons". To match the stated intent, Logs should be sidebar_order: 2, with Tracing and Profiling adjusted accordingly.
DESCRIBE YOUR PR
See changes on https://sentry-docs-git-feat-php-nav-update.sentry.dev/platforms/php/ and all PHP platforms
Sidebar Sections
Added 'Features' section with organized feature pages
Added 'Configuration' section
Both sections now have proper headers and grouping
Features Section (sidebar_section: features)
Order: Capturing Errors → Logs → Tracing → Profiling → Crons
Renamed 'Usage' to 'Capturing Errors' (matching JS)
Added 'new' tag to Logs
Added 'beta' tag to Metrics
Reordered all features for consistency
Configuration Section (sidebar_section: configuration) Order: Enriching Events → Extended Configuration → Integrations → Data Management → Security Policy Reporting → Migration Guide → Troubleshooting
Follows the pattern established in #15440
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES