Dev

[gameknife]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @gameknife, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new batch script to simplify the execution of the PowerShell-based build process on Windows command prompts, improving developer experience. Concurrently, it reflects significant progress in addressing multi-platform build system challenges by updating the project plan to show several GitHub Actions workflow fixes as completed.

Highlights

• New Build Wrapper Script: A new build.bat script has been added to provide a convenient wrapper for the existing build.ps1 PowerShell script, allowing it to be executed from a standard Windows command prompt with argument parsing for build targets (e.g., --android, windows) and clean operations.
• Multi-Platform Build Plan Update: The plan.md document for fixing multi-platform build system issues has been updated, marking several tasks under 'Phase 1: GitHub Actions Workflow Fixes' as completed. This includes fixes for build.yml arguments for Windows, Linux, and macOS builds, as well as verification of workflow syntax.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/linux.yml
  • .github/workflows/macos.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a build.bat script to wrap the PowerShell build script, making it easier to run from a standard command prompt. It also updates a planning document. The new batch script is a good addition for convenience. My review includes a suggestion to make the argument parsing in build.bat more robust to prevent silently ignoring invalid options.

[gemini-code-assist]

The argument parsing logic could be more robust. Currently, any unrecognized argument (e.g., a mistyped flag like --cleen) is treated as a target. If another valid target is specified later, the invalid flag is silently ignored. This can hide errors and lead to unexpected build configurations.

I suggest adding a check to explicitly reject unknown flags (those starting with --). This will make the script fail fast and provide clearer error messages.

) else (
    if "%~1:~0,2%"=="--" (
        echo Unrecognized option: %~1 >&2
        exit /b 1
    )
    REM Assuming the non-flag argument is the target
    if /i "%~1"=="windows" (
        set "TARGET=windows-dev"
    ) else (
        set "TARGET=%~1"
    )
)

[Copilot]

Pull request overview

This pull request fixes multi-platform build system issues by standardizing build target arguments across GitHub Actions workflows and adding a Windows batch wrapper script. The changes ensure that platform-specific build presets from CMakePresets.json are used correctly in CI pipelines.

Key Changes:

• Updated CI workflows to use explicit build targets (macos-arm64, linux-release) instead of generic platform names
• Added build.bat wrapper script for Windows to simplify command-line builds with proper argument handling
• Marked Phase 1 tasks as completed in the project plan

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
conductor/tracks/fix_multiplatform_build_20251231/plan.md	Updated task completion status for Phase 1, marking all GitHub Actions workflow fixes as complete with commit references
build.bat	New Windows batch script that wraps build.ps1, providing convenient argument parsing for targets like windows, android, and --clean
.github/workflows/macos.yml	Changed build target from macos to macos-arm64 to match the specific CMake preset for ARM64 architecture
.github/workflows/linux.yml	Changed build target from linux to linux-release to match the specific CMake preset for release builds

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.