Skip to content

Conversation

@jerzyjamroz
Copy link
Contributor

No description provided.

@jerzyjamroz jerzyjamroz requested a review from dirk-zimoch June 23, 2025 12:24
@jerzyjamroz jerzyjamroz linked an issue Jun 23, 2025 that may be closed by this pull request
# configuration: default
# base: "7.0"
# rtems: "4.10"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any opinion on RTEMS is outside my competence. I suggest @mdavidsaver reviews this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirk-zimoch This is something I am not sure about because rtems: "4.9" works without problems. It would be good if the author of rtems: "4.10" does the review. I commented it out with a note. This was already not working for a long time regardless of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One idea for handling that is to create a GitHub issue about rtems: "4.10" and merge this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current state of the epics-base GHA jobs is that the RTEMS 4.10 build does not run tests. There are also RTEMS 5.1 jobs.

https://github.com/epics-base/epics-base/blob/7.0/.github/workflows/ci-scripts-build.yml#L111-L149

@AppVeyorBot
Copy link

Build devlib2 1.0.37 failed (commit dd026d1d5a by @jerzyjamroz)

@dirk-zimoch
Copy link
Contributor

Still the AppVeyor builds fail. But not where it failed before. No idea what the problem is.

@jerzyjamroz
Copy link
Contributor Author

@dirk-zimoch , if you don't mind I would merge it, anyway the actual .ci does not work at all.

base: "7.0"

- os: ubuntu-20.04
- os: ubuntu-22.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to switch to ubuntu-latest to avoid some future churn?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For stability, pick a specific version. Perhaps ubuntu-24.04? Then, a few years to revisit the decision.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to switch to ubuntu-latest to avoid some future churn?

Done.

@AppVeyorBot
Copy link

Build devlib2 1.0.39 failed (commit 454add61e9 by @jerzyjamroz)

@dirk-zimoch
Copy link
Contributor

@dirk-zimoch , if you don't mind I would merge it, anyway the actual .ci does not work at all.

What's the point of merging as long as the AppVeyor jobs still don't work?

@jerzyjamroz
Copy link
Contributor Author

@dirk-zimoch , if you don't mind I would merge it, anyway the actual .ci does not work at all.

What's the point of merging as long as the AppVeyor jobs still don't work?

because Github ci works at least, plus one can do another PR dedicated to AppVeyor.

@dirk-zimoch
Copy link
Contributor

@dirk-zimoch , if you don't mind I would merge it, anyway the actual .ci does not work at all.

What's the point of merging as long as the AppVeyor jobs still don't work?

because Github ci works at least, plus one can do another PR dedicated to AppVeyor.

If it improved the situation, I approve. But I still rather had a solution that works for all builds. But this is not my repo, so Michael should have the last word. And I have only minor understanding of the whole .ci business, so I can't help fixing it.

@mdavidsaver
Copy link
Collaborator

If it improved the situation, I approve. But I still rather had a solution that works for all builds

I agree on both points. I think it is reasonable to figure out the GHA RTEMS and Appveyor builds separately.

@jerzyjamroz
Copy link
Contributor Author

Ok, so I merge this PR, but one can continue issue #21 as stated above.

@jerzyjamroz jerzyjamroz merged commit d95da30 into epics-modules:master Jun 27, 2025
25 of 28 checks passed
@jerzyjamroz jerzyjamroz mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.ci needs update

5 participants