Skip to content

Conversation

@jerzyjamroz
Copy link
Contributor

@jerzyjamroz jerzyjamroz commented Aug 22, 2025

Updates:

  • added permissions to .yml files
  • codeql for the module and kmod
  • check-editorconfig.yml

@mdavidsaver , I realised that the kmod in linux directory was not updated so i did it. But a question appears, where it is used? It looks like mrfioc2 repeats some code in its kmod? What is the purpose of this pci_generic_msi.c?

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@AppVeyorBot
Copy link

Build devlib2 1.0.43 failed (commit 452f62b77b by @jerzyjamroz)

@jerzyjamroz jerzyjamroz merged commit 9098e19 into epics-modules:master Aug 26, 2025
13 of 14 checks passed
@jerzyjamroz jerzyjamroz deleted the gha branch August 26, 2025 08:16
@anjohnson
Copy link
Member

There were no GHA builds of this PR on Windows, and the 4 Appveyor builds that ran all failed. If devlib2 isn't intended to be used on Windows (which seems likely) please remove the .appveyor.yml file so it won't run there (I hope that's how to do that). If it is supposed to be compatible there is still some work to do.

@jerzyjamroz
Copy link
Contributor Author

jerzyjamroz commented Aug 27, 2025

@anjohnson, as we discussed in epics-modules/devlib2#22, the plan was to address non-working parts in separate PRs (one per issue).
How to handle .appveyor.yml is up to @mdavidsaver.
The goal of this PR was to improve GHA and code quality, without introducing changes.

@jerzyjamroz jerzyjamroz linked an issue Aug 27, 2025 that may be closed by this pull request
@jerzyjamroz
Copy link
Contributor Author

@anjohnson , @mdavidsaver , my optional proposal is here: #24. I tried something with appveyor but it is mega slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.ci needs update

3 participants