Skip to content

Conversation

@Alonski
Copy link
Member

@Alonski Alonski commented Mar 6, 2018

This is a Work In Progress

I have currently updated Ember to v2.18.2

While trying to update to v3.0.0 I ran into an issue with this deprecation:
An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:

I have updated all plugins that I could with all tests passing (might have missed a few)
Currently there are still some addons that are not updated enough.
I will try to create PRs for these addons to fix them and would love some help.
These are:

  1. https://github.com/mike-north/ember-anchor - Fixed by using forks. Not a long term solution
  2. https://github.com/kimroen/ember-cli-document-title - PR accepted. New version updated.
  3. https://github.com/cardstack/ember-data-fastboot - PR accepted. New version updated. Thanks @ef4
  4. https://github.com/HeroicEric/ember-normalize - This addon is deprecated. Removed. Add deprecation notice to README HeroicEric/ember-normalize#19

Update 3/19/18

I have successfully updated to v3.0.0 and the app runs however tests are failing. Working on getting them fixed

Update 4/9/18

I reupdated to v3.0.0 but without the new test syntax. I couldn't get that running

@Gaurav0
Copy link
Contributor

Gaurav0 commented Mar 7, 2018

@Alonski That is an ember-cli deprecation. It did not prevent my work app from upgrading to Ember 3.0.

@Alonski
Copy link
Member Author

Alonski commented Mar 8, 2018

@Gaurav0 I am trying to update Ember-CLI to v3.0.0 along with all Ember dependencies.

From my testing this deprecation is causing build errors in v3.0.0

"broccoli-merge-trees": "^2.0.0",
"ember-a11y-testing": "^0.5.1",
"ember-algolia": "^0.0.10",
"ember-anchor": "Alonski/ember-anchor#new-cli",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you've opened a PR for this, can you make an issue in this repo linking to that PR so that we can swap it back when it gets merged?

@sivakumar-kailasam
Copy link
Member

Note for reviewers: There's a bourbon update in this PR, we'll have to look around the app to make sure styles are intact before we merge

@toddjordan
Copy link
Contributor

to address #469

@Alonski
Copy link
Member Author

Alonski commented Apr 11, 2018

Thanks @toddjordan. I forgot to link to the issue

@sivakumar-kailasam sivakumar-kailasam changed the base branch from master to 3-0-upgrade April 13, 2018 04:26
@sivakumar-kailasam sivakumar-kailasam merged commit 02663ca into ember-learn:3-0-upgrade Apr 13, 2018
@sivakumar-kailasam
Copy link
Member

I'm merging this PR into the 3-0-upgrade branch on this repo so that we can iterate over this and then merge to master. Thanks once again for tackling this @Alonski 🎉

@Alonski
Copy link
Member Author

Alonski commented Apr 13, 2018

@sivakumar-kailasam awesome. If I have fixes for a few things should I make a PR to that branch?

@sivakumar-kailasam
Copy link
Member

@Alonski yes please :)

Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
…d_yarn/guidemaker-1.1.0

Bump guidemaker from 1.0.2 to 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants