-
-
Notifications
You must be signed in to change notification settings - Fork 111
Updating Ember to v3.0.0 #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Alonski That is an ember-cli deprecation. It did not prevent my work app from upgrading to Ember 3.0. |
|
@Gaurav0 I am trying to update Ember-CLI to v3.0.0 along with all Ember dependencies. From my testing this deprecation is causing build errors in v3.0.0 |
| "broccoli-merge-trees": "^2.0.0", | ||
| "ember-a11y-testing": "^0.5.1", | ||
| "ember-algolia": "^0.0.10", | ||
| "ember-anchor": "Alonski/ember-anchor#new-cli", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you've opened a PR for this, can you make an issue in this repo linking to that PR so that we can swap it back when it gets merged?
|
Note for reviewers: There's a bourbon update in this PR, we'll have to look around the app to make sure styles are intact before we merge |
|
to address #469 |
|
Thanks @toddjordan. I forgot to link to the issue |
|
I'm merging this PR into the |
|
@sivakumar-kailasam awesome. If I have fixes for a few things should I make a PR to that branch? |
|
@Alonski yes please :) |
…d_yarn/guidemaker-1.1.0 Bump guidemaker from 1.0.2 to 1.1.0
This is a Work In Progress
I have currently updated Ember to v2.18.2
While trying to update to v3.0.0 I ran into an issue with this deprecation:
An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:I have updated all plugins that I could with all tests passing (might have missed a few)
Currently there are still some addons that are not updated enough.
I will try to create PRs for these addons to fix them and would love some help.
These are:
Update 3/19/18
I have successfully updated to v3.0.0 and the app runs however tests are failing. Working on getting them fixed
Update 4/9/18
I reupdated to v3.0.0 but without the new test syntax. I couldn't get that running